kz930 commented on PR #7149:
URL: https://github.com/apache/texera/pull/7149#issuecomment-5147532295
The tolerance fix looks right — count > (n * 5) // 100 is exactly
equivalent to count / n > 5% at every group count, not just multiples of 100.
**One note on the tests**: the runtime test is the only one of the ten
that exercises the tolerance, and it cancels in CI — the amber job has an
interpreter but no pandas or plotly. The nine that do run pin the exact emitted
text, so they go red on any rewrite, correct or not, and say nothing about
behavior.
**Solution**: amber already has the shape for this — AMBER_TEST_FILTER in
amber/build.sbt plus the IntegrationTest tag under amber/src/test/integration,
with amber-integration as the job that provisions Python
(it installs amber/requirements.txt and amber/operator-requirements.txt,
which pin pandas 2.2.3 and plotly 5.24.1). A Python-forking test wants to sit
behind that kind of tag, in a job that has the deps.
WorkflowOperator has no equivalent wiring today — the filter is scoped to
amber/build.sbt, and amber-integration runs only WorkflowExecutionService/test
— so it looks like a follow-up rather than something
to hold this PR for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
