kz930 opened a new issue, #7186:
URL: https://github.com/apache/texera/issues/7186

   ### Task Summary
   
   The `amber` job runs the `WorkflowOperator` module's tests and installs no 
Python packages. A test that executes a generated operator template needs 
pandas and plotly, fails its dependency probe, and calls `cancel(...)` — which 
is neither a pass nor a failure, so the suite still reports "All tests passed".
   
   PR #7149 hits this: of its ten new tests, the only one that actually 
executes the generated guard is the one that cancels.
   
   | Commit | Tests run | Canceled | Verdict |
   | --- | --- | --- | --- |
   | main (`ba63cedf`) | 2016 | 0 | All tests passed |
   | #7149 (`e9ac8bad`) | 2025 | 1 | All tests passed |
   
   **Fix — mirror the split `amber` already uses.** `amber/build.sbt` reads 
`AMBER_TEST_FILTER`: the `amber` job sets it to `skip-integration` and excludes 
`@IntegrationTest` specs, while `amber-integration` sets it to 
`integration-only`, runs just those, and installs `amber/requirements.txt` and 
`amber/operator-requirements.txt` (pandas 2.2.3, plotly 5.24.1). 
`WorkflowOperator` has none of this wiring, so a Python-executing test there 
has nowhere to run. Four steps:
   
   1. Add an `IntegrationTest` tag annotation under 
`common/workflow-operator/src/test`. `amber`'s tag can't be reused — it lives 
in `amber/src/test/integration`, and `amber` depends on `WorkflowOperator`, not 
the reverse.
   2. Add a `Test / testOptions` filter to `common/workflow-operator/build.sbt` 
reading the same `AMBER_TEST_FILTER` — `-l <tag>` on `skip-integration`, `-n 
<tag>` on `integration-only`. The `amber` job already sets that variable in the 
step that invokes `WorkflowOperator/jacoco`, so no workflow change is needed 
there.
   3. Add `"WorkflowOperator/test"` to the `amber-integration` sbt invocation, 
which already runs `integration-only` with the Python dependencies installed.
   4. Tag the Python-executing test in #7149 so it lands in that job.
   
   Net effect: the test stops cancelling in the unit job and starts executing 
in the integration job.
   
   ### Task Type
   
   - [x] DevOps / Deployment / CI
   - [x] Testing / QA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to