mengw15 opened a new issue, #7253: URL: https://github.com/apache/texera/issues/7253
### Task Summary `SiteSettings` (`common/dao/src/main/scala/org/apache/texera/dao/SiteSettings.scala`, codecov ~9%) is a small jOOQ-backed key/value settings store. Bring it to full unit coverage. Its existing `SiteSettingsSpec` only exercises the "SqlServer unavailable → return the default" path (the read swallows failures); the uncovered lines are the **DB-hit paths** — `readAndParse` when a value IS present, which `getInt` / `getLong` route through, plus the write helpers. These are unit-testable on embedded Postgres via `MockTexeraDB` (see #6714) — no infra beyond that. ### Behavior to add Add a `MockTexeraDB` setup (`with MockTexeraDB`, `initializeDBAndReplaceDSLContext()` in `beforeAll`) so `SqlServer.createDSLContext()` resolves to the embedded DB, then bring the file to full coverage — run the coverage report and cover the remaining red lines. The gap is the DB-hit path, so at minimum: - `getInt` / `getLong` with the key present in the DB → the stored value is parsed and returned; a non-numeric stored value → the default (parse-failure branch). - `upsert` / `insertIfAbsent` if a coverage run shows their DB-write branches uncovered — seed via one, read back via the other. Keep the existing "SqlServer unavailable → default" cases as-is. Explore the local coverage output to catch any remaining unit-testable lines. ### Task Type - [ ] Refactor / Cleanup - [ ] DevOps / Deployment / CI - [x] Testing / QA - [ ] Documentation - [ ] Performance - [ ] Other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
