Copilot commented on code in PR #7254:
URL: https://github.com/apache/texera/pull/7254#discussion_r3699290798
##########
amber/src/test/scala/org/apache/texera/web/resource/CollaborationResourceSpec.scala:
##########
@@ -42,10 +51,26 @@ class CollaborationResourceSpec
extends AnyFlatSpec
with Matchers
with MockFactory
- with BeforeAndAfterEach {
+ with BeforeAndAfterAll
+ with BeforeAndAfterEach
+ with MockTexeraDB {
Review Comment:
Mixing MockTexeraDB into the whole CollaborationResourceSpec makes all of
the existing “pure websocket” unit tests pay the embedded Postgres setup cost
(and now also run cleanupAccess deletes) even though only the 3 new
TryLockRequest cases need DB-backed hasWriteAccess. Consider splitting the
DB-backed lock tests into a separate spec that mixes in MockTexeraDB, keeping
this spec lightweight and fast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
