kz930 opened a new pull request, #7256: URL: https://github.com/apache/texera/pull/7256
### What changes were proposed in this pull request? `plotType` — the **Plot Type** field — was a plain string whose two legal values existed only in its description, so the form rendered a free-text box. It now declares them as a schema `enum`, which ngx-formly renders as a dropdown; `ECDFPlotOpDesc` already declares its string modes this way, so no frontend change is involved. The property's declared name stays `line`, since that is what saved workflows carry, and the generator's fallback is untouched. ### Why are the changes needed? The value is matched exactly — `if (plotType == "area") "px.area" else "px.line"` — so anything else draws a line chart and reports nothing. Generating the module on `main`: | Plot Type | Generated call | | --- | --- | | `area` | `px.area(table, ...)` | | `Area` — capitalised | `px.line(table, ...)` | | `aera` — one letter off | `px.line(table, ...)` | `Area` is the sharp case: likely to be typed, and the result is indistinguishable from having asked for a line chart. ### Does this PR introduce any user-facing change? Yes. Plot Type becomes a dropdown of `line` and `area`. Saved workflows carrying either are unaffected; one carrying anything else was already drawn as a line and still is. ### How was this patch tested? `WorkflowOperator/compile`, `scalafmtCheckAll`, and `TimeSeriesOpDescSpec` (13 tests). That suite pins the fallback by setting `plotType = "bar"` directly and asserting `px.line`; it bypasses the form, so it still passes. Closes #7251 Generated-by: Claude Code (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
