aglinxinyuan opened a new issue, #7276:
URL: https://github.com/apache/texera/issues/7276

   ### Task Summary
   
   `LakeFSStorageClient` carries four members that nothing calls. A repo-wide 
grep confirms each:
   
   | Member | Callers | Note |
   | --- | --- | --- |
   | `stagingApi` | none at all | private field, unreferenced even inside the 
class |
   | `removeFileFromRepo` | none | distinct from the live 
`GitVersionControlLocalFileStorage.removeFileFromRepo` |
   | `retrieveFileContent` | none | byte-for-byte duplicate of 
`getFileFromRepo`, which is live |
   | `withCreateVersion` | 1 test | `DatasetResourceSpec`, with an empty 
`operations` block; `createCommit` is the live equivalent |
   
   Delete them and move that one test call site to `createCommit`.
   
   `writeFileToRepo` has no production caller either, but three suites 
(`DatasetResourceSpec`, `StagedFileCleanupJobSpec`, 
`LakeFSStorageClientMtimeSpec`) use it to stage a file, and no other public 
staging entry point remains once `stagingApi` is gone — so it stays.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [ ] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to