aglinxinyuan opened a new issue, #7302:
URL: https://github.com/apache/texera/issues/7302

   ### Task Summary
   
   `ProjectResourceSpec` covers the create / rename / describe / add / remove / 
delete paths, but three of the resource's methods are never called by it:
   
   - **`updateProjectColor`** — has real validation. The guard rejects anything 
that is not 3 or 6 hex digits, checking length *and* hex-ness: a length-only 
check would let `"GGGGGG"` through, and a regex-only check would let `""` 
through. Worth covering both accept forms (the value is stored verbatim, not 
expanded), a rejected update leaving the previous colour intact, and the null 
check, which has to precede the length read or a null colour becomes an NPE 
rather than a 400.
   - **`deleteProjectColor`** — clears the value.
   - **`listProjectWorkflows`** — filters by project id through 
`DashboardResource.searchAllResources`. Needs two projects each holding one 
workflow, otherwise a filter that ignored the pid would still pass.
   
   The spec already mixes in `MockTexeraDB` with seeded users and workflows, so 
these are additions to the existing fixture rather than new infrastructure.
   
   For reference, `WorkflowVersionResource` (12 missed, 88.4%) was looked at as 
a companion and left alone: every one of its methods is already exercised by 
its spec, so the residue is branch-level and did not look worth chasing without 
risking padded tests.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to