Copilot commented on code in PR #7288:
URL: https://github.com/apache/texera/pull/7288#discussion_r3709723086
##########
frontend/package.json:
##########
@@ -26,7 +26,7 @@
"@angular/cdk": "21.2.14",
"@angular/common": "21.2.18",
"@angular/compiler": "21.2.19",
- "@angular/core": "21.2.18",
+ "@angular/core": "21.2.19",
Review Comment:
Angular framework packages are expected to be kept on the same patch
version. With `@angular/core` now at 21.2.19 while
@angular/common/@angular/forms/@angular/localize/etc remain at 21.2.18, the
lockfile shows exact peer deps (e.g., @angular/[email protected] peers on
`@angular/core` 21.2.18), which will produce unmet peer dependency warnings and
can lead to hard-to-debug runtime/compiler issues. Please bump the rest of the
@angular/* framework packages to 21.2.19 in this block (keeping `@angular/cdk`
as-is if intentional).
##########
frontend/LICENSE-binary:
##########
@@ -247,7 +247,7 @@ Angular / npm packages:
- @angular/[email protected]
- @angular/[email protected]
- @angular/[email protected]
- - @angular/[email protected]
+ - @angular/[email protected]
- @angular/[email protected]
Review Comment:
LICENSE-binary is now out of sync with the Angular patch-level updates that
are required to keep Angular packages aligned. If the dependency set is updated
to @angular/* 21.2.19 (recommended to satisfy exact peer deps), please update
the corresponding Angular entries here as well
(animations/common/forms/platform-browser/router).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
