carloea2 commented on code in PR #7258:
URL: https://github.com/apache/texera/pull/7258#discussion_r3715709988
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/visualization/timeSeriesplot/TimeSeriesOpDesc.scala:
##########
@@ -30,6 +30,19 @@ import
org.apache.texera.amber.operator.metadata.{OperatorGroupConstants, Operat
import javax.validation.constraints.{NotBlank, NotNull}
+// type constraint: the time axis is an instant and the plotted value is a
measurement.
+// Neither is enforced today: a non-time column is coerced with
errors='coerce', so
+// every row becomes NaT and the dropna that follows reports an empty table
without
+// naming the cause, and a text value column silently degenerates the y axis
into a
+// categorical one.
+@JsonSchemaInject(json = """
+{
+ "attributeTypeRules": {
+ "timeColumn": { "enum": ["timestamp"] },
Review Comment:
This rejects valid string date columns even though the generated code
deliberately supports them with pandas date conversion. Sources that preserve
date text as strings work today but will become invalid in the editor. Please
allow string columns or use validation that can distinguish valid date text
from bad values. Add one valid string date test and one bad string test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
