Copilot commented on code in PR #7322:
URL: https://github.com/apache/texera/pull/7322#discussion_r3717718892
##########
frontend/src/app/dashboard/component/user/files-uploader/files-uploader.component.spec.ts:
##########
@@ -148,6 +148,96 @@ describe("FilesUploaderComponent", () => {
expect((await emitted).map(item => item.name)).toEqual(["same.csv"]);
});
+ /**
+ * The Restart choices are the half of the conflict dialog the existing
tests never take. They
+ * differ from Resume by exactly one observable: `item.restart`, which is
what makes the uploader
+ * call the backend with type=forceRestart instead of continuing the
existing multipart session.
+ * A Resume/Restart mix-up therefore silently resumes a session the user
asked to discard.
+ */
Review Comment:
The doc comment says `item.restart` “stays unset”, but
`FileUploadItem.restart` is a required boolean and is initialized to `false` in
`fileDropped(...)`. Wording this as a `false -> true` transition makes the test
intent and observable consistent with the production type/behavior.
This issue also appears in the following locations of the same file:
- line 171
- line 222
- line 235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
