aglinxinyuan opened a new issue, #7433:
URL: https://github.com/apache/texera/issues/7433
### Task Summary
`FormlyRepeatDndComponent`'s spec drives `onDrop` directly and never
renders, so everything the template owns is unexercised: one row per entry,
which index a row's remove button carries, the drag handle, and whether the
section is editable at all.
The remove index is the one that matters:
```html
<div *ngFor="let field of field.fieldGroup; let i = index" ...>
<button (click)="remove(i)" class="dnd-remove-button" ...>
```
A fixed or off-by-one index deletes someone else's row, and every row looks
identical on screen.
Worth noting for whoever writes this: assert the drag handle on the
`cdkDragHandle` **directive**, not the `.drag-handle` class. The class is
styling and survives the directive being dropped, which would leave the row
undraggable while a class-based assertion still passed.
The remove buttons' disabled state should be left unasserted for now — it
never takes effect, see #7431.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
