aglinxinyuan opened a new issue, #7432:
URL: https://github.com/apache/texera/issues/7432
### Task Summary
The dataset explorer's toolbar and upload panel are template-only, and the
existing suite drives component state without asserting on what reaches the
screen. Roughly 70 template lines are uncovered.
The part worth pinning is the download gating. Both the per-file and
whole-version downloads are guarded by:
```html
[disabled]="!isLogin || !isDownloadAllowed()"
```
Each half matters independently — being signed in is not on its own
permission to copy someone else's non-downloadable dataset — and neither half
is currently exercised.
Also unpinned: exactly one of Maximize/Minimize showing (both, or the wrong
one, leaves the user with no way back); the copy-path control appearing only
once a file is on screen; the file size and version creation time appearing
only when known; and the upload panel reporting no statistics while
initializing, live speed and both timings while running, and a single total
once finished or aborted.
Two structural notes for whoever picks this up:
- `nz-tabs` only instantiates the active tab, and this toolbar lives in the
second one ("Versions & Files"), so nothing in it exists until that tab is
selected.
- The upload panel is gated on the separate `activeUploads` counter rather
than on `uploadTasks`, and ng-zorro collapses it by default, so both have to be
arranged before its body renders.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
