aglinxinyuan opened a new pull request, #7443:
URL: https://github.com/apache/texera/pull/7443
### What changes were proposed in this PR?
Whether this row offers any editing is decided in the template by **two**
conditions, not one:
```html
*ngIf="editable && entry.accessPrivilege === 'WRITE'"
```
The list being editable is not on its own permission to change someone
else's dataset. The existing suite exercises the component's methods and never
renders, so neither condition was pinned.
Adds 8 tests covering both halves independently — a reader on an editable
list gets no rename or add-description control, and neither does a writer on a
non-editable list — plus the same pair guarding the inline description, the
owner and shared-access markers being mutually exclusive, the shared marker
naming the privilege held, and the rename input being seeded from the dataset's
name.
**Verified by mutation**, all reverted (template diff empty):
| Mutation | Result |
|---|---|
| rename gate drops the WRITE check | red |
| rename gate drops the editable check | red |
| description gate drops the WRITE check | red |
| inline description gate drops the WRITE check | red |
| show the owner marker to everyone | red |
| show the shared marker to the owner too | red |
| invert the name / edit-input branch | red |
| seed the rename input from the description | red |
Testing both halves separately is the point: dropping either condition alone
still leaves a single-condition test passing.
The shared-marker mutation **survived its first run** — the owner test
asserted its own marker was present but not that the shared one was absent. It
is now exclusive.
No production file is touched.
### Any related issues, documentation, discussions?
Closes #7440
### How was this PR tested?
```
npx ng test --watch=false
--include="**/user-dataset-list-item.component.spec.ts"
```
```
Test Files 1 passed (1)
Tests 28 passed (28)
```
8 new on top of the existing 20. `yarn format:ci` passes.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
