aglinxinyuan opened a new pull request, #7446:
URL: https://github.com/apache/texera/pull/7446
### What changes were proposed in this PR?
Acts on the removal notice `ExpansionGreedyScheduleGenerator` has carried
since #3542. Pure deletion, no behaviour change: **−832 lines**.
| Removed | Lines | Why it is dead |
| --- | ---: | --- |
| `engine/architecture/scheduling/ExpansionGreedyScheduleGenerator.scala` |
495 | no caller since #3144 |
|
`engine/architecture/scheduling/ExpansionGreedyScheduleGeneratorSpec.scala` |
337 | covers only the above |
#3144 ("Refactoring of Schedule Generation", 2024-12-14) made
`CostBasedScheduleGenerator` the only generator the engine constructs. #3542
(2025-07-09) then annotated the greedy one with the notice it still carries
today:
> This greedy schedule generator will be removed in the future. Use
`CostBasedScheduleGenerator` instead.
```
WorkflowScheduler.scala:46 -> new CostBasedScheduleGenerator(...) (live,
untouched)
ExpansionGreedyScheduleGenerator
(unreachable since #3144)
```
No configuration can bring it back: the `schedule-generator` block in
`application.conf` holds only CostBased tuning parameters
(`max-concurrent-regions`, `use-global-search`, `use-top-down-search`,
`search-timeout`, read at `ApplicationConfig.scala:87-90`), with no
generator-selection key.
> Reviewer note: the abstract base `ScheduleGenerator` is **not** touched —
`CostBasedScheduleGenerator` extends it and is unaffected. Only the greedy
subclass and its spec are removed.
### Any related issues, documentation, discussions?
Closes #7444
### How was this PR tested?
Existing tests only — this PR adds none, since it removes code and the spec
that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success (main and test
sources).
Verification that nothing references the removed class, re-runnable by a
reviewer:
```
git grep -n ExpansionGreedy # only the two deleted files
git grep -in greedy -- '*.conf' '*.yml' '*.yaml' '*.json' '*.properties' #
no generator-selection key
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
