aglinxinyuan opened a new issue, #7449:
URL: https://github.com/apache/texera/issues/7449
### Task Summary
`EmptyReplayLogger` is a no-op `ReplayLogger` that the log-replay factory no
longer reaches — it is never instantiated.
| Symbol | Location | Lines (src + spec) |
| --- | --- | ---: |
| `EmptyReplayLogger` |
`amber/.../engine/architecture/logreplay/EmptyReplayLogger.scala` | 41 + 130 |
The null-object role moved up a layer to `EmptyReplayLogManagerImpl`, which
implements the no-ops inline:
```
ReplayLogManager.scala:51 -> EmptyReplayLogManagerImpl (inline no-ops,
live)
ReplayLogManager.scala:109 -> new ReplayLoggerImpl() (the only
ReplayLogger built in main)
EmptyReplayLogger (never
instantiated)
```
No configuration selects a logger class by name, so there is no path that
revives it. The abstract base `ReplayLogger` stays — `ReplayLoggerImpl` extends
it.
It acquired unit tests during the 2026 coverage work, which is why it
currently looks live. The spec covers this class and nothing else, so it goes
with it.
Pure deletion, no behaviour change: −171 lines.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
