aglinxinyuan opened a new issue, #7454:
URL: https://github.com/apache/texera/issues/7454
### Describe the bug
`WorkflowWebsocketResource.myOnMsg` reads the current execution twice, and
only one of the two reads is null-safe.
```scala
// line 89 — correct
val executionStateOpt = workflowStateOpt.flatMap(x =>
Option(x.executionService.getValue))
// line 124 — the `other` branch
workflowStateOpt.map(_.executionService.getValue) match {
case Some(value) => value.wsInput.onNext(other, uidOpt)
case None => throw new IllegalStateException("workflow execution is
not initialized")
}
```
`executionService` is a `BehaviorSubject` seeded with `null`, so `getValue`
returns `null` until an execution actually starts. `.map` on a `Some` wraps
that into `Some(null)` — the `case None` arm is therefore unreachable, and
`value.wsInput` throws a `NullPointerException` instead.
The friendly "workflow execution is not initialized" message can never be
produced for the case it was written for.
### To Reproduce
1. Open a workflow websocket session and let it subscribe to a workflow (so
`workflowStateOpt` is defined).
2. Do **not** start an execution.
3. Send any runtime frame that falls through to the `other` branch — e.g.
`WorkflowPauseRequest` or `WorkflowKillRequest`.
Expected: `IllegalStateException("workflow execution is not initialized")`.
Actual: `NullPointerException` on `value.wsInput`.
Both are caught by the surrounding error mapper and rethrown, so the client
sees a `WorkflowFatalError` either way — but its text is an NPE stack trace
rather than the intended message.
### Expected behavior
The `other` branch should use the same null-safe read as line 89:
```scala
workflowStateOpt.flatMap(x => Option(x.executionService.getValue)) match {
```
`executionStateOpt` is already computed on line 89 and is exactly this
value, so the branch can simply reuse it.
### Additional context
Found while assessing this file for test coverage. Deliberately **not**
pinned by a test, since encoding the current behaviour would cement the bug —
noted here instead so a future coverage PR does not do so by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
