mengw15 opened a new pull request, #7469:
URL: https://github.com/apache/texera/pull/7469

   ### What changes were proposed in this PR?
   
   Extends the existing `TypeCastingDisplayComponent` spec so the schema table
   actually renders, covering the template that was previously never executed
   
(`frontend/src/app/workspace/component/property-editor/typecasting-display/type-casting-display.component.html`).
   No production code was changed.
   
   4 tests cover every branch of the template:
   
   - the outer `*ngIf` — no `nz-table` is rendered while the type-casting
     information is hidden;
   - the header cells (`Attribute Name` / `Attribute Type`);
   - the table's no-data arm for an empty schema;
   - the `*ngFor` row — one row per attribute, asserting each row's name and 
type
     cell text against the seeded schema (mixed `long` / `string` / `double`).
   
   One note on the empty-schema case: `nz-table` renders a single placeholder 
row
   rather than no rows at all. The test asserts the *shape* of that arm (one row
   with one spanning cell) instead of the placeholder's text, which comes from 
the
   active locale bundle and would make the assertion brittle.
   
   Per the usual constraints: no fake timers, and no layout or geometry 
assertions.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7465
   
   ### How was this PR tested?
   
   Extended unit tests, run locally in `frontend/` (all green; the failure path 
was
   verified by breaking an assertion to confirm the suite goes red):
   
   ```
   ng test --watch=false --include 
src/app/workspace/component/property-editor/typecasting-display/type-casting-display.component.spec.ts
   # Test Files 1 passed (1) | Tests 16 passed (16)
   prettier --write <spec>   # clean
   eslint  <spec>            # clean
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to