Neilk1021 commented on code in PR #7339: URL: https://github.com/apache/texera/pull/7339#discussion_r3752733153
########## frontend/src/app/hub/component/login/texera-login.component.scss: ########## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +$text-secondary: rgba(0, 0, 0, 0.45); +$error: #ff4d4f; +$bg: #f0f2f5; +$card-bg: #fff; + +:host { + display: flex; + align-items: center; + justify-content: center; + min-height: 100vh; + padding: 32px 16px; + background: $bg; + -webkit-font-smoothing: antialiased; +} + +* { + box-sizing: border-box; +} + +.card { + width: 100%; + max-width: 400px; + background: $card-bg; + border-radius: 8px; + box-shadow: + 0 6px 16px -8px rgba(0, 0, 0, 0.08), + 0 9px 28px 0 rgba(0, 0, 0, 0.05), + 0 12px 48px 16px rgba(0, 0, 0, 0.03); + padding: 40px 36px 32px; +} + +.brand { + display: flex; Review Comment: The main issue is that if i make the subheading a div then it justifies the text up, so I have to do hack-y work arounds to get it centered without using flex. I'm down to move sub to being a div instead of a span, but then I need to make that div flex so I can justify the text. I need to justify the text because otherwise it creates padding at the bottom. (I tried this and tested a few different approaches which is why I'm bringing this up.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
