kz930 commented on PR #7207: URL: https://github.com/apache/texera/pull/7207#issuecomment-5249146081
All seven are addressed in `baded3f5a`, and I reproduced both design findings before changing anything. `-I` does hide PYTHONPATH: `PYTHONPATH=<dir> python3 -I -S -c "import <mod>"` raises ModuleNotFoundError while dropping `-I` imports it, and a non-`PYTHON*` variable survives either way. The parameter stays; the example is now the thing that says so. `TestFilters` errors on an unrecognized value. Only the two recognized values appear anywhere in the repo, so nothing existing changes, and a typo now fails the build instead of running the full suite in a job that asked for a subset. The description's 96 % is gone the same way its code twin went. I also fixed one the round missed: the description still said the executor stops anything being submitted past the cap, which you corrected in the code last round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
