kz930 opened a new pull request, #7567:
URL: https://github.com/apache/texera/pull/7567

   ### What changes were proposed in this PR?
   
   Dumbbell Plot took the distinct values of the compared column and sorted 
them. An empty cell reaches the operator as `None`, so `unique()` returned a 
list with a `None` in it and `sorted` compared `None` against a string, ending 
the run with a TypeError.
   
   An empty value is ordinary input here. A blank CSV cell arrives as null, 
since univocity returns null for an empty field and 
`AttributeTypeUtils.parseField` passes it through by design.
   
   It now drops rows missing any of the three columns it reads, which is what 
the other visualization operators do: twenty-four of them open their generated 
Python with `dropna(subset=[...]) #remove missing values`, and Dumbbell Plot 
was the one that did not. A table left empty by the drop renders the operator's 
own error rather than an exception, matching how it already reports an empty 
input.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7562
   
   ### How was this PR tested?
   
   `DumbbellPlotOpDescSpec` gains a case asserting the generated Python drops 
on all three configured columns before it sorts. It fails on the previous 
behavior, 7 passed / 1 failed before the change and 8 / 0 after.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to