Yicong-Huang commented on code in PR #7122:
URL: https://github.com/apache/texera/pull/7122#discussion_r3785220157
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/Coordinator.scala:
##########
@@ -41,9 +42,12 @@ import org.apache.texera.amber.engine.common.ambermessage.{
DirectControlMessagePayload,
WorkflowFIFOMessage
}
+import org.apache.texera.amber.engine.common.rpc.AsyncRPCClient
import org.apache.texera.amber.engine.common.virtualidentity.util.{CLIENT,
COORDINATOR, SELF}
import org.apache.texera.amber.engine.common.{CheckpointState, SerializedState}
import org.apache.texera.web.SessionState
+import org.apache.texera.amber.core.virtualidentity.ActorVirtualIdentity
+import com.twitter.util.Promise
Review Comment:
The regrouping is reverted — the net diff here is additions only now. What
is left is where they sit. These two, plus `PekkoActorRefMappingService` at
`:30` and `AsyncRPCClient` at `:45`, land after the block's last entry rather
than in alphabetical position; `RegionExecutionManagerTestSupport.scala:60`
does the same with `Coordinator`.
One more line while you are here: `RegionExecutionManager.scala:64` has a
blank between `AtomicReference` and `scala.concurrent.duration` that `main`
does not.
No `.scalafmt.conf` import rule will flag either — advisory, not worth a
round on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
