Yicong-Huang commented on code in PR #76: URL: https://github.com/apache/incubator-texera-site/pull/76#discussion_r3788548605
########## hugo.toml: ########## @@ -144,19 +150,19 @@ enable = false # End user relevant links (left side footer & "Are you a User?" community section) [[params.links.user]] name = "Quick Start" -url = "/docs/latest/getting-started/" +url = "/docs/DOCS_VERSION/getting-started/" icon = "fa fa-rocket" desc_key = "quickstart_desc" [[params.links.user]] -name = "Releases" -url = "/releases/" +name = "Downloads" +url = "/downloads/" icon = "fa fa-download" desc_key = "releases_desc" Review Comment: change this key as well? ########## .gitignore: ########## @@ -1,5 +1,9 @@ /public resources/ + +# Versioned docs are pulled from the texera repo at build time by +# scripts/sync-docs.sh; only content/docs/_index.md is tracked here. +/content/docs/*/ Review Comment: are there more stuff under this folder? if not we can remove the folder? ########## hugo.toml: ########## @@ -93,8 +93,14 @@ contributingUrl = "https://github.com/apache/texera/blob/main/CONTRIBUTING.md"; # Latest release shown discreetly in the footer. # Update these two values when shipping a new version. -latest_release = "1.1.0-incubating" -latest_release_url = "/releases/1.1.0-incubating/" +latest_release = "1.2.0-incubating" +latest_release_url = "/releases/1.2.0-incubating/" + +# Documentation version that site-wide doc links point to (footer, community +# page, etc.). Links in this file use the literal token DOCS_VERSION, which is +# resolved to this value at render time. Update this one value when a new docs +# version becomes the default. +docs_version = "v1.2.0" Review Comment: I think the url should still be rendered as "latest" then a router should route "latest" to "v1.2.0" (redirect). we should not change the url itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
