aglinxinyuan opened a new issue, #7695:
URL: https://github.com/apache/texera/issues/7695

   ### Task Summary
   
   Three frontend files sit well below their neighbours, and the gaps are all 
in behaviour never driven end to end:
   
   | File | Lines |
   |---|---|
   | `workspace/service/workflow-websocket/workflow-websocket.service.ts` | 
76.0% |
   | 
`workspace/component/property-editor/port-property-edit-frame/…component.ts` | 
86.5% |
   | `dashboard/component/user/user-quota/user-quota.component.ts` | 90.1% |
   
   None is blocked by #7458 -- these are `.ts` files, so there is no 
template-attribution problem. They are simply untested paths: the websocket 
handshake URL's query construction and the heartbeat, the Yjs/Quill binding and 
its DOM triggers, and the quota component's per-day aggregation and chart 
wiring.
   
   Traps worth knowing before writing anything here, each of which produces a 
test that passes while pinning nothing:
   
   1. **Degenerate fixtures make swaps invisible.** If two chart divs, two 
series, or two query-string slots carry values that render identically, 
exchanging them is undetectable. Use distinguishable values, and prefer a true 
*exchange* over replacing one side with a constant.
   2. **Resetting one accumulator can be masked by another.** Dropping 
`this.workflows = []` leaves `workflows.length` unchanged, because executions 
get re-filed under the existing panels. An idempotence test must pin the 
per-workflow contents, not the count.
   3. **`vi.mock` is unreliable in this repo.** `@angular/build` hard-codes 
`isolate:false`, so the first importer of a module pins it -- a spec can be 
green solo and red in CI. Prefer DI overrides and real objects.
   4. **Asserting a handler ran is not asserting the template invokes it.** The 
Yjs binding's `(click)`, `(focusout)` and `(keyup.enter)` wiring each need a 
DOM-level test; calling the method directly leaves all three deletable.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to