Copilot commented on code in PR #7717:
URL: https://github.com/apache/texera/pull/7717#discussion_r3793685124
##########
frontend/vitest.config.ts:
##########
@@ -34,6 +34,15 @@ export default defineConfig({
// which Angular's `fakeAsync` requires. Karma+Jasmine installed this
// implicitly; the @angular/build:unit-test path doesn't.
setupFiles: ["src/test-zone-setup.ts"],
+ // Headroom over Vitest's defaults (5s test / 10s hook) for the shared
+ // macos-latest runners, whose wall time swings ~2x run to run: the same
+ // test that takes ~400ms on ubuntu has been observed at 11s+ in a
+ // beforeEach on a loaded macOS runner, and the leg was failing on pure
+ // timeouts in a different spec nearly every time (#7713). Roughly 4x/3x
+ // the worst observed times; a genuinely hung test still fails, just a
+ // few seconds later on a 9-17 minute leg.
Review Comment:
Optional: This rationale conflates the defaults with the observed runtimes.
The new limits are 4x/3x the 5s/10s defaults—not the worst observed times—and a
hang can now take 15–20 seconds longer to report rather than only “a few”
seconds. Please keep the comment consistent with the measured rationale in the
PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
