aglinxinyuan opened a new issue, #7732:
URL: https://github.com/apache/texera/issues/7732

   ### Task Summary
   
   Two small frontend targets, both live and both partly untested:
   
   | File | Coverage |
   |---|---|
   | `workspace/service/preset/preset.service.ts` | 91.7% lines, 6 missed + 4 
partial |
   | 
`workspace/component/result-panel/console-frame/console-frame.component.html` | 
93.5% lines, 6 missed — and **0 of 8 branches, 5 of 9 functions** |
   
   The template's branch and function figures are the real gap; its line 
percentage hides it.
   
   Worth establishing before writing anything, because both guesses turn out to 
be wrong in instructive ways:
   
   - **`preset.service.ts` is live**, not another 
`workflow-snapshot.service.ts`. It is injected by `preset-wrapper.component.ts` 
and `operator-property-edit-frame.component.ts`, and its `user/config` endpoint 
is served by `UserConfigResource.scala`.
   - **The template is NOT an #7458 case.** The existing spec uses `imports: 
[ConsoleFrameComponent, ...]` with no `overrideComponent`, and the coverage map 
proves bindings execute counted — the `*ngFor` statement shows 124 hits. This 
is a partly-untested template, not a lost source map, so the remedy is to 
extend the existing TestBed rather than append a fresh one.
   
   Traps here:
   
   1. **The settings dropdown's menu is projected into a CDK overlay** wired in 
`ngAfterViewInit` behind an `auditTime(150)`. The fixture must be created 
*inside* `fakeAsync` — created in a plain `beforeEach`, the timers escape 
`tick()` and the overlay never attaches, so a test asserting on its contents 
finds zero elements and can be written to "pass" vacuously.
   2. **Toggling two switches off at once hides a swap.** Asserting timestamp 
and source independently is what makes an exchange of their `[(ngModel)]` 
bindings detectable.
   3. **Four uncovered items are unreachable and should be left alone** — see 
below; two of them are production defects, and a test would cement them.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to