Copilot commented on code in PR #7754: URL: https://github.com/apache/texera/pull/7754#discussion_r3807425431
########## sql/updates/38.sql: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +\c texera_db + +SET search_path TO texera_db; + +BEGIN; + +-- The Lakekeeper catalog name is no longer derived from the user-facing name +-- (#7753), and the table already has its own `name` column -- so the old +-- `warehouse_name` was ambiguous. Rename it to sit beside its sibling +-- `lakekeeper_warehouse_id`. The table is empty in every deployment (the +-- warehouse feature flag is off everywhere), so this carries no data. +ALTER TABLE user_warehouse + RENAME COLUMN warehouse_name TO lakekeeper_warehouse_name; Review Comment: This rename fails when a fresh local-dev database already contains `lakekeeper_warehouse_name` from `texera_ddl.sql`: local-dev replays unrecorded change sets and only tolerates “already exists” errors, while PostgreSQL reports that `warehouse_name` does not exist. Guard the rename so it is a no-op when the target schema is already present, as `sql/updates/33.sql:238-252` does for its column rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
