tanishqgandhi1908 opened a new pull request, #7760:
URL: https://github.com/apache/texera/pull/7760
### What changes were proposed in this PR?
Datasets and models need the same three rules: who owns a resource, who it
is shared with, and whether a name is already taken. Today those rules live
inside the dataset code, so adding models means copying them.
This PR moves them into one shared implementation and points datasets at it.
Since jOOQ generates an unrelated class per table, there is no common parent to
inherit from — instead a small descriptor says which columns to look at, and the
shared code works off that.
No behaviour change for datasets, apart from one fix: `GET
/access/dataset/owner/{did}` and `GET /access/dataset/list/{did}` had no
authorization, so any signed-in user could read any dataset's owner email and
full share list. Both now require read access. Anyone who could already see the
dataset is unaffected.
### Any related issues, documentation, discussions?
Prepares the shared layer for #6498 (umbrella #6494).
### How was this PR tested?
The existing dataset suites are the regression evidence, since this changes
how
the dataset code is wired without changing what it does:
- `sbt "FileService/test"` — 236/236, including `DatasetResourceSpec` (118)
- `sbt "WorkflowCore/test"` — 773/773
- `scalafmtCheckAll` and `scalafixAll --check` clean
`DatasetAccessResourceSpec` gains tests for the two guards. One existing
expectation changed: a nonexistent id returned an empty string and now returns
403.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
