mengw15 commented on code in PR #7745:
URL: https://github.com/apache/texera/pull/7745#discussion_r3810831147
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/warehouse/WarehouseResource.scala:
##########
@@ -53,16 +54,47 @@ object WarehouseResource {
name: String,
warehouseName: String,
flavor: String,
- createdAtMillis: Long
+ createdAtMillis: Long,
+ // Owner display info, mirroring DashboardWorkflowComputingUnit: today
every
+ // warehouse belongs to the caller, but the UI binds to the entry rather
than
+ // the session user so shared warehouses render the right person (#7743).
+ ownerName: String,
+ ownerAvatar: String
)
- private def toDashboardWarehouse(row: UserWarehouseRecord):
DashboardWarehouse =
+ // (name, avatar) per uid; null when the user has no name / avatar set,
matching
+ // how computing units resolve their owner info.
+ private def resolveOwners(uids: Seq[Integer]): Map[Integer, (String,
String)] =
Review Comment:
`resolveOwners` is gone here — with the listing joined and `create` reading
the session user, nothing on this side batch-fetches users any more; only a
two-line null collapse remains.
CU still has `resolveOwnerInfo` and still needs it: that listing reconciles
against Kubernetes pod phases mid-flight, so by the time it resolves owners it
holds an in-memory collection, not a query it can join. So the two are no
longer the same code — I'd suggest leaving them as they are for now, but happy
to revisit if you see it differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
