aicam commented on code in PR #6858:
URL: https://github.com/apache/texera/pull/6858#discussion_r3825148970
##########
bin/k8s/values.yaml:
##########
@@ -310,7 +310,7 @@ texeraEnvVars:
- name: SCHEDULE_GENERATOR_ENABLE_COST_BASED_SCHEDULE_GENERATOR
value: "true"
- name: MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB
- value: "64"
+ value: "1024"
Review Comment:
Right, that was an oversight rather than a dev/prod split — fixed in
`b558dfe4e`: `values-development.yaml:310` is now `"1024"`, matching
`values.yaml`.
I checked the third chart too: `values-aws.yaml` doesn't set
`MAX_WORKFLOW_WEBSOCKET_REQUEST_PAYLOAD_SIZE_KB` at all, so it inherits the
`application.conf` default and needed no change. With the guard test in
`ApplicationConfigSpec` also updated, all four places that encoded 64 KB now
agree on 1024, and the description has been corrected to list them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
