tanishqgandhi1908 commented on code in PR #6869:
URL: https://github.com/apache/texera/pull/6869#discussion_r3827828132
##########
file-service/src/main/scala/org/apache/texera/service/FileService.scala:
##########
@@ -90,6 +92,8 @@ class FileService extends
Application[FileServiceConfiguration] with LazyLogging
environment.jersey.register(classOf[DatasetResource])
environment.jersey.register(classOf[DatasetAccessResource])
+ environment.jersey.register(classOf[ModelResource])
+ environment.jersey.register(classOf[ModelAccessResource])
Review Comment:
Correct, and deliberate — routing lands with the frontend PR (#6499), since
nothing calls these endpoints until the UI exists. Direct :9092 is the only way
in today. I'll note it in the description.
Thanks for the plural warning. /api/models routes to access-control-service
for the LLM catalog in all three configs, and in nginx it's an exact-match
location = /api/models. Our path is /api/model, so no clash today, but a prefix
rule for models would swallow it — I will keep in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
