mengw15 commented on code in PR #7819: URL: https://github.com/apache/texera/pull/7819#discussion_r3833537354
########## frontend/src/app/dashboard/component/user/user-warehouse/user-warehouse-list-item/user-warehouse-list-item.component.html: ########## @@ -0,0 +1,88 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<nz-card + [nzBodyStyle]="{padding: '3px'}" + class="warehouse-list-item-card"> + <div + nz-row + nzAlign="middle" + class="warehouse-item-row"> + <div + nz-col + nzFlex="20px"></div> + + <div + nz-col + nzFlex="0" + class="type-icon"> + <i + nz-icon + nzType="cloud-server"></i> + </div> + + <div + nz-col + nzFlex="0" + class="warehouse-id"> + <i>#{{ warehouse.whid }}</i> + </div> + + <div + nz-col + nzFlex="1" + class="resource-name-group"> + <div + class="resource-name truncate-single-line" + nz-tooltip + [nzTooltipTitle]="warehouse.name" + (click)="openWarehouseMetadataModal()"> Review Comment: Same as the delete control above: the computing-unit row opens its details dialog from a plain `div` too. Worth one accessibility pass over both tabs. ########## frontend/src/app/common/component/warehouse-create-modal/warehouse-create-modal.component.html: ########## @@ -0,0 +1,52 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<nz-modal + [nzVisible]="visible" + nzTitle="Create Warehouse" + [nzContent]="createWarehouseModalContent" + [nzFooter]="createWarehouseModalFooter" + (nzOnCancel)="handleCreateWarehouseModalCancel()"> + <ng-template #createWarehouseModalContent> + <input + nz-input + placeholder="Warehouse name" Review Comment: Added a visible label in da35c4b7c: the field now sits in a labelled group like the computing-unit modal's fields. ########## frontend/src/app/dashboard/component/dashboard.component.html: ########## @@ -109,6 +109,18 @@ nzType="deployment-unit"></span> <span>Compute</span> </li> + <li + *ngIf="warehouseEnabled" + nz-menu-item + nz-tooltip="Manage warehouses" + nzMatchRouter="true" Review Comment: Added the exact commands to the test section. Screenshots are coming before this leaves draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
