aglinxinyuan opened a new issue, #7832: URL: https://github.com/apache/texera/issues/7832
### Task Summary Two files in the user-dataset explorer are high on statements but weak on branches and functions: | File | Coverage | |---|---| | `dataset-detail.component.ts` | 93.1% — 5 missed lines + **24 partial** | | `user-dataset-version-creator.component.ts` | 88.3% — 5 missed + 2 partial | Both templates were taken to 100% in merged PRs #7681 and #7772, which lifted these `.ts` files as a side effect — so what is left is branch arms and uncalled handlers, not whole untested regions. The 24 "partial" lines on `dataset-detail` are exactly the 24 distinct source lines carrying a missed branch arm. Neither is an instance of #7458 (no `TestBed.overrideComponent` in either spec) — the non-zero percentages already imply that. Two things to know before starting: 1. **One of the version-creator's 5 missed lines is dead code.** `get formControlNames(): string[]` — `grep -rn formControlNames frontend/src` returns exactly one hit, its own declaration. No template and no TypeScript references it. Do not cover it; deleting the getter is a separate production change. 2. **`dataset-detail.component.html:593`'s `[disabled]` binding does work**, contrary to an earlier report. `NgModel` routes it through `control.disable()`, deferred to a microtask, so the DOM lags one turn behind `detectChanges()`. Asserting immediately reads the stale value and invites the wrong conclusion. ### Task Type - [ ] Refactor / Cleanup - [ ] DevOps / Deployment / CI - [x] Testing / QA - [ ] Documentation - [ ] Performance - [ ] Other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
