aglinxinyuan opened a new issue, #7892:
URL: https://github.com/apache/texera/issues/7892

   ### Task Summary
   
   Two dashboard templates with small gaps that are entirely untested markup 
rather than an attribution artifact:
   
   | Template | Coverage |
   |---|---|
   | `admin/execution/admin-execution.component.html` | 93.9% — 5 missed of 82 
lines |
   | `user/user-dataset/user-dataset.component.html` | 86.5% — 5 missed of 37 
lines, branches 4/6 |
   
   Check first whether either is an instance of #7458 (the 
`TestBed.overrideComponent` attribution loss that several merged PRs in this 
area already fixed) — but verify rather than assume, in both directions.
   
   Traps worth knowing:
   
   1. **`admin-execution.component.html:128` is dead markup and cannot be 
covered.** `#endTimeNotAvailable` is declared twice, at lines 118 and 127, so 
lines 127-129 are unreachable. That is one of the five "missed" lines, so the 
realistic ceiling is 81/82.
   2. **A handler that a test calls directly stays `FNDA:0`.** Several bindings 
here — `(nzQueryParams)`, `(nzFilterChange)`, and the card-view `(click)` — 
have their handlers invoked directly by the existing suites, so the *bindings* 
are never fired. Deleting one would silently break every page click and no test 
would notice. These are worth zero Codecov lines, so they are a behaviour gap 
rather than a coverage one; decide deliberately whether to pin them.
   3. **One binding must be left unpinned.** `(refresh)="ngAfterViewInit()"` on 
`user-dataset.component.html:100` would cement a duplicate-subscription defect 
if pinned.
   4. **One line has no `DA` record in the lcov at all**, so it can never count 
toward the Codecov metric in either direction — do not chase it.
   5. **`ng test --coverage` writes no lcov when any test fails**, so measure 
only from a green run. `frontend/junit.xml` is regenerated every run and is not 
gitignored; committing it fails the license-header check.
   
   Note the backend counterpart `AdminExecutionResource` was assessed earlier 
and rejected with bytecode proof, so there is nothing to gain by wandering into 
it.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to