mengw15 commented on code in PR #7594:
URL: https://github.com/apache/texera/pull/7594#discussion_r3840148470
##########
build.sbt:
##########
@@ -279,6 +279,9 @@ lazy val NotebookMigrationService = (project in
file("notebook-migration-service
)
.dependsOn(DAO % "test->test") // test scope dependency
+// Playwright automation recording the per-operator demo videos linked from
docs/reference/operators/.
+lazy val DemoVideoGenerator = (project in file("docs/operator-demo-videos"))
Review Comment:
The module lives under `docs/`, so `.github/labeler.yml` gives a module-only
PR just the `docs` label, and `docs` maps to no stacks in precheck's
`LABEL_STACKS`. Follow-up PRs that only add files under
`docs/operator-demo-videos/**` will therefore skip every Scala leg — no
compile, no scalafmtCheckAll/scalafixAll, no tests. This PR is covered only
because it also touches `build.sbt` (`common`) and `.github/**` (`ci`).
##########
docs/operator-demo-videos/src/test/scala/org/apache/texera/demovideos/controllers/ControllerBuilderSpec.scala:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.texera.demovideos.controllers
+
+import org.scalatest.flatspec.AnyFlatSpec
+import org.scalatest.matchers.should.Matchers
+
+import scala.collection.mutable.ArrayBuffer
+
+class ControllerBuilderSpec extends AnyFlatSpec with Matchers {
Review Comment:
The spec passes locally (`sbt DemoVideoGenerator/test`, and it fails if
`execute()` is mutated), but no CI leg runs it: the amber job's coverage step
uses an explicit list (`want=(DAO Auth Config Resource Util PyBuilder
WorkflowCore WorkflowOperator WorkflowCompiler WorkflowExecutionService)`), and
`scalafixAll --check` only compiles the test sources. Separately, the module
doesn't apply `commonModuleSettings`, so `DemoVideoGenerator/jacoco` emits HTML
only — no `jacoco.xml` for the codecov glob to pick up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
