zyratlo opened a new pull request, #7934:
URL: https://github.com/apache/texera/pull/7934

   ### What changes were proposed in this PR?
   `bin/local-dev.sh` had no knowledge of the notebook migration tool, so a 
contributor running the local dev stack got the tool in the GUI with nothing 
serving it. This PR registers both pieces with the local dev tooling.
   
   **`bin/local-dev/main.sh` (service catalog)**
   - Registers `notebook-migration-service` as a managed JVM service on port 
9098, following the same catalog shape as the other single module services. No 
launch case is needed because `start_one` is generic over the catalog, and no 
dirty-source entry is needed because `_precompute_src_dirs` derives the 
transitive source closure from the sbt project name.
   - Registers `jupyter` as Docker infrastructure on port 9100 and adds it to 
the sets that `up` starts and that state reporting reads, so it appears in the 
dashboard rather than only starting silently.
   - The startup summary counted containers with a literal that is now wrong. 
It reads the length of the long lived infrastructure list instead, so it cannot 
drift again.
   
   **`bin/local-dev/tui.py` (dashboard catalog)**
   - Adds the matching rows so both services appear in the interactive 
dashboard. Order matches `main.sh`, whose array is documented as start order.
   
   **`bin/local-dev/README.md`**
   - Documents rebuilding the JupyterLab image. It is the only managed service 
running from a Texera built image rather than natively, so edits to its 
customizations do nothing until it is rebuilt. Also notes deleting the local 
tag afterwards, since it otherwise shadows the published image and the 
contributor keeps running a stale build.
   
   ### Any related issues, documentation, discussions?
   Closes #7933
   Parent issue #4301
   
   Depends on #7932, which defines the `jupyter` compose service and its image.
   
   ### How was this PR tested?
   The existing suite passes: `bin/local-dev/tests/test_local_dev_sh.sh` (117). 
The catalog invariants in `bin/local-dev/tests/test_local_dev_tui.py` are 
covered in CI's `infra` job.
   
   Manually verified that `bin/local-dev.sh status` renders both new services 
with the right ports and reaches no fatal path, which exercises the transitive 
source-dir resolution for the new sbt project. Also confirmed the two catalogs 
agree on name, type, port, and order, and that `bash -n` and `py_compile` are 
clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   Generated-by: Claude Code (Claude Opus 5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to