aglinxinyuan opened a new issue, #7955:
URL: https://github.com/apache/texera/issues/7955
### Task Summary
`frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.ts`
sits at 97.4% — 2 missed and 9 partial of 422 lines — after an earlier pass
covered the bulk of it. The residue is small but it includes the
upload-progress paths, which are the ones a user actually watches.
Worth knowing before writing anything:
1. **Two branch arms cannot be covered and should not be chased.**
`percentage: progress.percentage ?? this.uploadTasks[taskIndex].percentage ??
0` (line 647) and its twin in the error handler (line 678) both fall back
through a `??` whose right operand is unreachable given the callers. Verified
in lcov: the line is hit 28 times with both arms at zero.
2. **Report the function counters (FNF/FNH), not just lines.** Twice in this
campaign a file sat at high line coverage with functions uncovered, and a
binding whose handler a spec calls *directly* stays `FNDA:0` while looking
covered. Here they happen to be 120/120 both before and after — worth
confirming rather than assuming.
3. **A time-zone test written against the ambient `Intl` formatter is
degenerate.** Asserting on whatever the runner's locale produces pins nothing;
stub the formatter so the assertion is about the component's parsing
(`.split(", ").pop()`) rather than the platform's output.
4. **A single-index test can be degenerate too.** "Ignores a hide request
for a row that is gone" and the basename test both pass trivially unless a
valid-index half is asserted alongside the invalid one.
5. **A fresh worktree has no `frontend/node_modules`.** Junction it from the
main checkout — and **remove the junction before finishing**, because a
recursive delete that follows it destroys the main checkout's `node_modules`.
That happened during this campaign.
6. `ng test --coverage` writes no lcov at all if any test fails, so measure
only from a green run. `frontend/junit.xml` and `frontend/coverage/` are
regenerated every run and must not be committed.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
