Copilot commented on code in PR #7951:
URL: https://github.com/apache/texera/pull/7951#discussion_r3850152701
##########
frontend/src/app/workspace/service/drag-drop/drag-drop.service.spec.ts:
##########
@@ -605,4 +605,114 @@ describe("DragDropService", () => {
expect(outputOps.map(o => o.operatorID)).toEqual([sinkNear.operatorID]);
});
});
+ /**
+ * findIntersectedLink's loop body has never executed: every existing call
site either has no
+ * links, no attached paper, or mocks the method out. It is what decides
whether dropping an
+ * operator onto an edge splices it into that edge, so it is worth running
for real — jointjs
+ * renders link views synchronously, so a real paper works in jsdom.
+ */
Review Comment:
The new block comment says the loop body “has never executed” and that
“every existing call site” has no links/paper or mocks the method out, but this
spec file already has a `findIntersectedLink` test case that calls the method
with an attached paper. Reword this comment to be precise about what was
previously unexercised (the rendered `.connection`/geometry intersection path),
so future readers aren’t misled.
This issue also appears on line 642 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
