mengw15 commented on issue #7963: URL: https://github.com/apache/texera/issues/7963#issuecomment-5406710444
Dropping the `filters.component.html` half of this issue: it is not reachable in this test environment, and part of it is being deleted anyway. **Every target is inside a CDK overlay.** All nine uncovered statements the issue named (44, 69, 100-101, 134-135, 171-172, 207-209) sit inside `<nz-dropdown-menu>`. `NzDropdownMenuComponent`'s whole template is wrapped in an `<ng-template>` whose `<ng-content>` is only instantiated when the overlay attaches, and the overlay never attaches under jsdom. Probed two ways: - seed the collection, `detectChanges()`, then click `.search-owners-button` — 0 checkboxes in view, and the injected `OverlayContainer` element stays empty (`innerHTML.length === 0`) through a microtask, a macrotask and a 300 ms real wait; - resolve all six `NzDropdownDirective` instances, set `nzVisible = true` and call `ngOnChanges`, inside `fakeAsync` with `tick(0)` then `tick(500)` — the overlay container is still empty. This is the same wall as #7651, #7655 and #7840. Forcing it would need an unbounded real wait, which is exactly the flake the CI matrix punishes. **`filters.component.ts` is already at 100 %** — 215/215 statements, 84/84 branches, 62/62 functions. The gap is purely template lines that live behind the overlay. **The project block is being removed.** #7463 deletes the `#projectSearchOptions` dropdown from `filters.component.html` (-34 lines), which is items 207-209 here, so covering them would be writing tests for markup on its way out. The list-item half is done in the PR below; the issue body has been trimmed to that half. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
