tanishqgandhi1908 commented on PR #6872: URL: https://github.com/apache/texera/pull/6872#issuecomment-5414875307
Fixed in both, using `getOwner(ctx, id).getEmail`. Added a spec case that uploads and creates the version as a second user holding `WRITE` — it fails on the old code with the collaborator's email in the path. Pushed in `6daa5af`. FileService is green at 336 tests. Note the version-name length, the version scoping and the `operationType` NPE all exist in `DatasetResource` too. Fixing them there needs its own tests and a `dataset_version` migration against real data, so I am doing that as a follow-up rather than widening this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
