aglinxinyuan opened a new issue, #7986: URL: https://github.com/apache/texera/issues/7986
### Task Summary Five small frontend gaps, bundled because each is only 3-4 lines on its own: | File | Coverage | |---|---| | `common/service/workflow-util.service.ts` | 94.6% — and **5 of its 18 functions are uncovered** | | `common/service/user/config/user-config.service.ts` | 93.7% | | `workspace/service/workflow-version/workflow-version.service.ts` | 96.9% | | `workspace/component/.../breakpoint-condition-input.component.ts` | 88.9%, branches 28/33, functions 7/8 | | `workspace/component/.../nz-modal-comment-box.component.html` | 90.2% | The function counters are the signal worth acting on — `workflow-util.service.ts` has four zero-caller methods plus a map lambda that no test enters, which its 94.6% line figure hides completely. Always report FNF/FNH here, not just lines. Traps, each of which has cost real time in this repo: 1. **A fresh worktree has no `frontend/node_modules`, and you must do a real install** — `node .yarn/releases/yarn-4.14.1.cjs install --immutable --inline-builds --network-timeout=100000` from `frontend/`, about 40s off the global Berry cache. Do **not** junction it from the main checkout: any later recursive delete follows the junction and empties the main checkout's dependencies, and it also reaches through yarn's portal link and deletes the tracked files under `frontend/tools/jschardet-stub`, after which `yarn install` fails with `Manifest not found`. 2. **`ng test --coverage` writes no lcov at all if any test fails.** Measure only from a green run. The file lands at `frontend/coverage/gui/lcov.info` — note the `gui` subdirectory. 3. **`frontend/junit.xml` is regenerated every run and is not gitignored**; committing it fails the licence-header check. 4. **lcov's line records do not always line up with branch records.** For one multi-line statement here, lcov emits `BRDA:59,...` with no `DA:59` (the statement's line record is `DA:58`), so a DA-restricted count and a union count disagree by one. Say which rule you are using. 5. Never pass `--browsers` (it silently runs zero tests), and remember the builder typechecks *every* spec, so a type error anywhere fails the run. Two regions are unreachable and should be left alone: `workflow-version.service.ts`'s else-arms at lines 174 and 198, and `user-config.service.ts`'s private `updateEntry` guards. ### Task Type - [ ] Refactor / Cleanup - [ ] DevOps / Deployment / CI - [x] Testing / QA - [ ] Documentation - [ ] Performance - [ ] Other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
