anthonychengit opened a new pull request, #8003:
URL: https://github.com/apache/texera/pull/8003

   ### What changes were proposed in this PR?
   
   Nested autofill properties now determine requiredness from the JSON Schema 
object that directly owns the property.
   
   | | Before | After |
   | --- | --- | --- |
   | Required property in a `$ref` definition | Could receive an invalid empty 
option | Receives only propagated attribute names |
   | Optional nested property sharing a root-level name | Could lose its empty 
option | Retains the empty option |
   
   `DynamicSchemaService.mutateProperty` supplies the owning schema to its 
match and mutation callbacks. `WorkflowCompilingService` uses that schema's 
`required` array when constructing autofill enums.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7826.
   
   ### How was this PR tested?
   
   Added positive and negative regression coverage for required and optional 
nested properties, plus callback coverage for the owning schema.
   
   ```text
   cd frontend
   node node_modules\@angular\cli\bin\ng.js test --watch=false --include 
src/app/workspace/service/dynamic-schema/dynamic-schema.service.spec.ts 
--include 
src/app/workspace/service/compile-workflow/workflow-compiling.service.spec.ts
   ```
   
   Result: 2 test files passed; 62 tests passed.
   
   ```text
   cd frontend
   node .yarn\releases\yarn-4.14.1.cjs run format:ci
   git diff --check
   ```
   
   Result: both commands completed successfully.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Codex was used for implementation and verification assistance. 
I reviewed the final code and test output before submission.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to