tanishqgandhi1908 commented on code in PR #8000:
URL: https://github.com/apache/texera/pull/8000#discussion_r3876048257
##########
common/config/src/main/resources/default.conf:
##########
@@ -95,6 +99,22 @@ dataset {
multipart_upload_chunk_size_mib = ${?DATASET_MULTIPART_UPLOAD_CHUNK_SIZE_MIB}
}
+model {
+ model_single_file_upload_max_size_mib = 2048
Review Comment:
Went with your first option — renamed the dataset params so both sections
match:
dataset { dataset_single_file_upload_max_size_mib = 20 }
model { model_single_file_upload_max_size_mib = 2048 }
Bare leaves in both sections isn't available: site_settings rows are keyed
by the leaf's
last path segment, so they collide and DefaultsConfig fails at load. Took
(a) over (b)
because full-path keys would rename every row, gui.* included.
Renaming the leaves renames the rows, so this adds sql/updates/42.sql to
move the four
existing ones — otherwise the seeder recreates them at defaults and an
admin's raised
limit is silently lost. Idempotent, tested against a scratch Postgres.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
