tanishqgandhi1908 opened a new pull request, #8060:
URL: https://github.com/apache/texera/pull/8060
### What changes were proposed in this PR?
The Owner filter on the Datasets pages was broken on both sides:
1. **Wrong list.** `<texera-filters>` always read its Owner and ID dropdowns
from `WorkflowPersistService`, so Datasets listed workflow owners and offered a
workflow-ID filter.
2. **No effect.** `VersionedResourceSearchQueryBuilder` applied the date, id
and full-text filters but dropped `params.owners`, so selecting an owner
changed nothing.
```
Before: Datasets -> filters -> workflowPersistService.retrieveOwners() ->
workflow owners
owner=<email> -> VersionedResourceSearchQueryBuilder ->
ignored
<img width="1239" height="533" alt="Screenshot 2026-08-27 at 3 36 49 PM"
src="https://github.com/user-attachments/assets/ca1f0055-17d3-46cb-b4c8-65a1005bec5f";
/>
After: Datasets -> filters -> datasetService.retrieveOwners() ->
dataset owners
owner=<email> -> VersionedResourceSearchQueryBuilder ->
USER.EMAIL predicate
```
<img width="1227" height="598" alt="Screenshot 2026-08-27 at 4 41 05 PM"
src="https://github.com/user-attachments/assets/294335e6-6028-44c2-af46-c2ad19781c97";
/>
- `filters.component.ts` gains `@Input() entityType`, defaulting to
`Workflow`, so the Workflows and
unified search pages are untouched.
- `VersionedResourceSearchQueryBuilder` adds the
`getContainsFilter(params.owners, USER.EMAIL)` the
workflow builder already uses. The `USER` join was already in the FROM
clause.
- The id dropdown hides where no id endpoint exists. Adding
`/dataset/user-dataset-ids` and
`/model/user-model-ids` is left to a follow-up feature.
### Any related issues, documentation, discussions?
Closes #8059.
### How was this PR tested?
Five new tests in `filters.component.spec.ts` (owners per kind, ids only for
workflows, dropdown
hidden for datasets) and three in `DatasetSearchQueryBuilderSpec` (one owner
renders the predicate,
several OR together but AND with the id filter, none renders nothing).
```bash
cd frontend && npx ng test $(grep -rl "FiltersComponent\|DatasetService"
src/app | grep "spec.ts$" | sed 's/^/--include /' | tr '\n' ' ')
sbt 'testOnly *DatasetSearchQueryBuilderSpec'
```
909 frontend tests, 21 backend, all passing. Plus `tsc --noEmit`, eslint,
prettier, `scalafmtCheck`.
Manual: signed in as a user with a shared dataset plus their own workflow,
the Datasets page now
lists only the dataset's owner, ticking it narrows the list, and the id
dropdown is gone. Workflows
page unchanged.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
