Yicong-Huang commented on code in PR #8071:
URL: https://github.com/apache/texera/pull/8071#discussion_r3883130445
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
Review Comment:
Two comments:
1. Ideally, I want the vote email to be short and concise, details maybe
found on the RC itself
2. If we need to include some detailed information, can we generate them
dynamically with the ground truth in the RC? For instance for the list of
images, I don't think we should hard code them in email source code, but to
detect what actual images are associated with the RC and list here. In this way
if we add a new image in future release, the email template does not need to be
changed.
##########
.github/release/vote-email-template.md:
##########
@@ -21,58 +21,75 @@ Subject: [VOTE] Release Apache Texera (incubating)
${VERSION} RC${RC_NUM}
Hi Texera Community,
-This is a call for vote to release Apache Texera (incubating) ${VERSION}.
+This is a call for a vote on releasing Apache Texera (incubating)
+${VERSION} RC${RC_NUM}.
== Release Candidate Artifacts ==
-https://dist.apache.org/repos/dist/dev/incubator/texera/${VERSION}-RC${RC_NUM}/
+https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/
-The directory contains:
-- Source tarball (.tar.gz) with GPG signature (.asc) and SHA512 checksum
(.sha512)
-- Docker Compose deployment bundle with GPG signature and SHA512 checksum
+The staging directory contains:
+- Source tarball (.tar.gz), with its GPG signature (.asc) and SHA-512 checksum
(.sha512)
+- Docker Compose convenience bundle, with its GPG signature and SHA-512
checksum
== Container Images ==
-Container images are available at:
- ${IMAGE_REGISTRY}/texera-dashboard-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-compiling-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-file-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-config-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-access-control-service:${VERSION}
- ${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${VERSION}
+The following convenience container images are available:
-These images are built from the source tarball included in this release.
-The Dockerfiles are included in the source for audit and verification.
+${IMAGE_REGISTRY}/texera-dashboard-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-coordinator:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-execution-runner:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-compiling-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-file-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-config-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-access-control-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-agent-service:${IMAGE_TAG}
+${IMAGE_REGISTRY}/texera-workflow-computing-unit-managing-service:${IMAGE_TAG}
-== Git Tag ==
+These images were built from the source tarball included in this release
candidate.
+
+== Git Tag and Commit ==
https://github.com/apache/texera/releases/tag/${TAG_NAME}
+
Commit: ${COMMIT_HASH}
-== Keys ==
+== KEYS ==
+
+https://downloads.apache.org/incubator/texera/KEYS
+
+The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL}).
-The release was signed with GPG key [${GPG_KEY_ID}] (${GPG_EMAIL})
-KEYS file: https://downloads.apache.org/incubator/texera/KEYS
+== Major Changes Since <PREVIOUS_RELEASE, e.g. Apache Texera 1.1.0-incubating>
==
+
+Full diff:
+https://github.com/apache/texera/compare/<PREVIOUS_TAG>...${TAG_NAME}
+
+Major changes include:
+<FILL IN: grouped highlights, verified against the previous release BRANCH,
+not its tag>
== Vote ==
-The vote will be open for at least 72 hours.
+The vote will remain open for at least 72 hours.
[ ] +1 Approve the release
[ ] 0 No opinion
-[ ] -1 Disapprove the release (please provide the reason)
+[ ] -1 Do not approve the release because...
== Checklist ==
+Please include the checklist below in your reply and mark the checks you
+performed with an x.
Review Comment:
This kind of new line would look awful in email. It looks fine in markdown
because markdown would render them continuously, but we are using this markdown
as a template for email.
Two things:
1. Can we change this template to .txt, since email won't use markdown
format.
2. Can we naturally leave sentences on the same line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
