kz930 opened a new pull request, #8080:
URL: https://github.com/apache/texera/pull/8080

   ### What changes were proposed in this PR?
   
   The operator answered an empty table with an error page and then handed the 
two configured columns to `ff.create_dendrogram` as they arrived. Two tables 
that pass that guard ended the run anyway: one with a blank in either 
coordinate, which scipy refuses with "The condensed distance matrix must 
contain only finite values", and one with a single row, which leaves it an 
empty distance matrix.
   
   It now drops the rows missing either coordinate and reports an emptied table 
with the wording Dumbbell Plot already uses, then answers a table with fewer 
than two rows. Only the coordinates are dropped on. A NaN anywhere in the point 
matrix makes scipy refuse the whole thing, while a blank label is just a blank 
tick on the axis and is no reason to lose the row.
   
   The row-count check reads after the drop, so a table the drop reduces to one 
row lands there rather than back in scipy.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8079
   
   ### How was this PR tested?
   
   Two cases added to DendrogramOpDescSpec, over the emitted code. I also ran 
the guarded body against each table in scipy: an empty table, a single row, 
three rows with one blank coordinate, a table the drop reduces to one row, a 
wholly blank coordinate column, two ordinary rows, and a row with a blank 
label. Each reaches the intended page, and the last two still draw.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to