carloea2 opened a new pull request, #8115:
URL: https://github.com/apache/texera/pull/8115

   ### What changes were proposed in this PR?
   
   Use the input directive's `readonly` binding for picker-generated dataset 
paths. This keeps the selected path visible while preventing keyboard edits. 
Manual path entry remains available when dataset file selection is disabled.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8114
   
   ### How was this PR tested?
   
   Regression test before the fix:
   
   `yarn test --include 
src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.spec.ts`
   
   The read-only assertion failed. The other 10 tests passed.
   
   Verification after the fix:
   
   `yarn test --include 
src/app/workspace/component/dataset-file-selector/dataset-file-selector.component.spec.ts`
   
   All 11 tests passed.
   
   `yarn format:ci`
   
   Formatting passed.
   
   Live verification in Chrome:
   
   1. Started Texera locally from this worktree.
   2. Added CSV File Scan to a workflow.
   3. Selected a dataset version file.
   4. Confirmed current main accepted a keyboard overwrite.
   5. Confirmed this branch rejected the same typing action and preserved the 
selected path.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Codex


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to