PG1204 commented on PR #6213: URL: https://github.com/apache/texera/pull/6213#issuecomment-5463945038
> > 🟡 **7 resolved · 1 open · 1 new** (1 new = 1 newly introduced · 0 late catches) — the blocker is properly closed; only two doc-level items remain. > > ### Conventions (2) > > > > * Description: the second view is still listed as "Throughput: seconds per output row", but the code and UI now say `TimePerRow` / "Time / row" (advisory) > > * Tests: the editor-side overlay wiring (`handleHeatmapOverlay`, `repaintHeatmapColors`, `restoreAllOperatorFills`, `handleHeatmapHover`) still has no spec — 33.33% patch coverage on `workflow-editor.component.ts` (advisory, carried over) > > > > Verification trace > > @Yicong-Huang thanks for the review, I have changed the description and shall track the overlay-wiring tests as a dedicated follow-up (issue #7491) to keep this PR focused, it'll include a regression test for the disable/enable repaint path. @Yicong-Huang all comments are addressed, requesting a re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
