aglinxinyuan opened a new pull request, #8178:
URL: https://github.com/apache/texera/pull/8178
### What changes were proposed in this PR?
Eight small frontend gaps, each too small to be worth a PR alone. **+9
fully-covered lines and +4 branch arms.**
| File | Codecov | Closed |
|---|---|---|
| `dashboard-entry.ts` | 117/119 → **119/119** | 205, 206 |
| `settings.component.ts` | 27/28 → **28/28** | 78 |
| `codearea-custom-template.component.ts` | 30/31 → **31/31** | 72 |
| `result-panel-modal.component.html` | 23/24 → **24/24** | 56 |
| `breakpoint-condition-input.component.html` | 8/9 → **9/9** | 27 (arms 0/2
→ **2/2**) |
| `hub-workflow-detail.component.html` | 45/46 → **46/46** | 27 |
| `search.component.ts` | 54/56 → 55/56 | 119 |
| `ui-udf-parameters-parser.service.ts` | 135/142 → 136/142 | 364 |
Six of the eight reach 100%.
### Verification
Measured against the **full** suite with no `--include` filter at all — 203
files / 5227 tests before, 203 / 5242 after, both green — because the `DA` line
set for a file depends on which specs are in the run, so a filtered
before/after pair can fabricate a delta. Parsed from `lcov.info` with Codecov's
rule applied directly: a line counts only if its `DA` hit is non-zero **and**
every `BRDA` arm on it is taken.
Two reviewers returned ten findings; all repaired. **The repair pass moved
coverage by exactly zero** — its three added tests are mutation-strength, not
coverage. The builder's figures reproduced line for line.
### Two equivalent mutants, reported rather than papered over
- `ui-udf-parameters-parser.service.ts:364` — `return parts.length ? parts :
undefined` → `return parts;` survives the full suite. Both callers of
`readMemberPath` treat `[]` and `undefined` identically, so it is not killable.
No test was written to pretend otherwise.
- `:349` — relaxing `parts?.length !== 2` to `parts.length < 2` survives for
the same reason.
Seven of the sixteen baseline gap lines across these files are given up
rather than chased.
Two files touched only by repaired specs are **not** claimed as gains:
`result-panel-modal.component.ts` (46/47) and
`hub-workflow-detail.component.ts` (98/99) are unchanged.
`yarn format:ci` passes. `frontend/junit.xml` is regenerated by every run,
is not gitignored, and is not committed. No production file is touched.
### Any related issues, documentation, discussions?
Closes #8176
### How was this PR tested?
```
npx ng test --watch=false
--include="**/ui-udf-parameters-parser.service.spec.ts"
--include="**/dashboard-entry.spec.ts" --include="**/search.component.spec.ts"
--include="**/settings.component.spec.ts"
--include="**/codearea-custom-template.component.spec.ts"
--include="**/result-panel-modal.component.spec.ts"
--include="**/breakpoint-condition-input.component.spec.ts"
--include="**/hub-workflow-detail.component.spec.ts"
```
```
Test Files 8 passed (8)
```
Re-run after rebasing onto current `main`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
