carloea2 opened a new pull request, #8184: URL: https://github.com/apache/texera/pull/8184
### What changes were proposed in this PR? Include schema equality when comparing Python tuples. This aligns equality with the schema types already used by tuple hashing. Before: `INTEGER` 1 and `DOUBLE` 1.0 compared equal but hashed to 32 and 1072693279. After: different schemas compare unequal, while same-schema tuples remain equal and hash-compatible. ### Any related issues, documentation, discussions? Closes #8183 ### How was this PR tested? The new regression was red before the source change at the different-schema comparison, then passed after the one-line fix. ```text python -c "import sys,pytest; sys.path[:0]=[r'<worktree>\amber\src\main\python',r'<checkout>\amber\src\main\python']; raise SystemExit(pytest.main([r'amber/src/test/python/core/models/test_tuple.py::TestTuple::test_tuple_equality_includes_schema','-q','-p','no:cacheprovider']))" ``` The model layer and partitioner suites pass: ```text python -c "import sys,pytest; sys.path[:0]=[r'<worktree>\amber\src\main\python',r'<checkout>\amber\src\main\python']; raise SystemExit(pytest.main([r'amber/src/test/python/core/models','-k','not test_hash','-q','-p','no:cacheprovider']))" python -c "import sys,pytest; sys.path[:0]=[r'<worktree>\amber\src\main\python',r'<checkout>\amber\src\main\python']; raise SystemExit(pytest.main([r'amber/src/test/python/core/models/test_tuple.py::TestTuple::test_hash_treats_none_fields_as_zero',r'amber/src/test/python/core/architecture/sendsemantics/test_partitioners.py','-q','-p','no:cacheprovider']))" ``` Results: 314 model tests passed with one expected failure, then the separately selected null-hash test and all 35 partitioner tests passed. Hash-named fixtures were separated because the existing `TestTuple.test_hash` uses a naive epoch timestamp that fails on Windows; PR #8174 makes it explicitly UTC. ```text ruff check amber/src/main/python amber/src/test/python ruff format --check amber/src/main/python amber/src/test/python ``` Ruff checked 213 files successfully. A direct production-class check confirmed same-schema dictionary lookup still works and different schemas remain two distinct keys. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex, GPT-5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
