carloea2 opened a new pull request, #8198:
URL: https://github.com/apache/texera/pull/8198
### What changes were proposed in this PR?
Remove a channel from its previous input port when registration reassigns it
to another port. The existing forward mapping update and new-port registration
remain unchanged.
Before: the forward map pointed to the new port, but both old and new port
alignment sets contained the channel.
After: only the new port contains the channel, so port control-message
alignment uses current membership.
### Any related issues, documentation, discussions?
Closes #8197
### How was this PR tested?
Regression test first:
$env:PYTHONDONTWRITEBYTECODE='1';
C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import sys,pytest;
sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\fix-pyamber-channel-reregistration\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python'];
raise
SystemExit(pytest.main([r'amber\src\test\python\core\architecture\packaging\test_input_manager.py','-q','-p','no:cacheprovider']))"
Before the source change: 20 passed and 1 failed. The failure showed the
reassigned channel still present on the old port.
After the fix, the input manager and embedded control-message manager suites
reported 28 passed:
$env:PYTHONDONTWRITEBYTECODE='1';
C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import sys,pytest;
sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\fix-pyamber-channel-reregistration\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python'];
raise
SystemExit(pytest.main([r'amber\src\test\python\core\architecture\packaging\test_input_manager.py',r'amber\src\test\python\core\architecture\managers\test_embedded_control_message_manager.py','-q','-p','no:cacheprovider']))"
C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe check
amber/src/main/python amber/src/test/python
C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe format --check
amber/src/main/python amber/src/test/python
Result: all checks passed and 213 files were already formatted.
The production InputManager probe now reports zero channels on the old port,
one on the new port, and false for membership in both.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex, GPT-5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
